Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

Run examples as part of the CI #32

Closed
betatim opened this issue Mar 29, 2016 · 4 comments
Closed

Run examples as part of the CI #32

betatim opened this issue Mar 29, 2016 · 4 comments
Labels
Build / CI Easy

Comments

@betatim
Copy link
Member

betatim commented Mar 29, 2016

Avoid broken examples like what happened in #29 by running them as part of travis. Not sure if there is anything more useful we can do than to check that they run with exit code == 0.
@glouppe
Copy link
Member

glouppe commented Jul 19, 2016

Shall we leave this open, provided examples will be eventually replaced with the notebooks?

@betatim
Copy link
Member Author

betatim commented Jul 19, 2016

Yes. One way would be calling nbconvert --execute and then thinking about how to detect failure.

@MechCoder MechCoder mentioned this issue Aug 23, 2016
Merged
@MechCoder MechCoder reopened this Aug 25, 2016
@MechCoder
Copy link
Member

Reopened since circleci could not catch the error in #209

@MechCoder
Copy link
Member

Fixed by 8d80445

holgern added a commit that referenced this issue Feb 19, 2020
@holgern
Merge pull request #32 from scikit-optimize/master
aa37a6d 
Add upstream changes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Build / CI Easy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@glouppe @betatim @MechCoder