-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vector Fitting: Custom pole initialization #845
Conversation
Hey, thanks a lot, looks fine, except for one small thing I noticed: in line 187ff. I think a check should be made whether or not the instance variable "self.poles" holds any poles... I don't think it's that relevant, but it's the only thing I noticed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Would like it to be included in the next release ?
Yes! I'm currently working on the last few tweaks. Almost done... |
I don't understand why the tests are failing. https://docs.pytest.org/en/6.2.x/warnings.html#pytest-mark-filterwarnings |
Ok now. I moved the tests to a separate PR (#850). This one is ready. |
@andree-sc: Thanks for the review! I added the parameter check. |
As requested in the mailing list, this PR adds an option for custom pole spacing by the user.
The pole spacing is a delicate part of the fitting process and this option is supposed to be used by advanced users only.
The goal was to keep the API unchanged, and I hope this is an elegant and usable way to do it.