Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector Fitting: Tests #850

Merged
merged 7 commits into from
Feb 19, 2023
Merged

Vector Fitting: Tests #850

merged 7 commits into from
Feb 19, 2023

Conversation

Vinc0110
Copy link
Collaborator

This is a branch from PR #845 to work on the tests separately. Work in progress...

msg_passivity_violation = 'The fitted network is passive, but the vector fit is not passive. Consider running ' \
'`passivity_enforce()` to enforce passivity before using this model.'

@pytest.mark.filterwarnings(f'ignore:*{msg_passivity_violation}*:UserWarning')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried without the * character?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't the *, but it now works in general form, without any message. That filters every UserWarning, which I think is fine in this case.

@Vinc0110 Vinc0110 marked this pull request as ready for review February 18, 2023 14:26
@Vinc0110 Vinc0110 merged commit 2e0519a into scikit-rf:master Feb 19, 2023
@Vinc0110 Vinc0110 deleted the vf_tests branch February 19, 2023 09:28
@jhillairet jhillairet mentioned this pull request Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants