Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stability circles #943

Merged
merged 12 commits into from
Sep 4, 2023
Merged

Stability circles #943

merged 12 commits into from
Sep 4, 2023

Conversation

keikawa
Copy link
Contributor

@keikawa keikawa commented Aug 20, 2023

This pull request adds stability circle calculation methods related to #362.

FranzForstmayr
FranzForstmayr reviewed Aug 21, 2023
View reviewed changes
skrf/network.py Outdated Show resolved Hide resolved
@jhillairet jhillairet added the New Feature A new feature in progress label Sep 1, 2023
jhillairet
jhillairet approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@jhillairet jhillairet left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, thank you.

Do you think you could write an associated notebook for the tutorial part of the documentation, to explain what are stability circles and how to use it?

@keikawa
Copy link
Contributor Author

keikawa commented Sep 1, 2023

That sounds good.
I'm planning to start by implementing the gain circle calculation methods and then move on to creating a notebook, because stability circles are typically used with gain circles, as requested in #362.
But, unfortunately, I'm currently busy this month due to preparations for conferences, so I'd prefer to send other pull requests for these tasks.

@jhillairet jhillairet merged commit 12f1c65 into scikit-rf:master Sep 4, 2023
11 checks passed
@jhillairet jhillairet mentioned this pull request Sep 4, 2023
Merged
@Vinc0110 Vinc0110 mentioned this pull request Jan 11, 2024
Closed
@keikawa keikawa mentioned this pull request Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FranzForstmayr FranzForstmayr FranzForstmayr left review comments

@jhillairet jhillairet jhillairet approved these changes

Assignees
No one assigned
Labels
Network New Feature A new feature in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@keikawa @jhillairet @FranzForstmayr