Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gain circle #998

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Add gain circle #998

merged 2 commits into from
Jan 22, 2024

Conversation

keikawa
Copy link
Contributor

@keikawa keikawa commented Jan 12, 2024

This is related to #362 and #943.

@Vinc0110 Vinc0110 linked an issue Jan 13, 2024 that may be closed by this pull request
Stability and gain circles #362
Closed
Vinc0110
Vinc0110 approved these changes Jan 13, 2024
View reviewed changes
Copy link
Collaborator

@Vinc0110 Vinc0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks for adding this PR to quickly!

I like the extensive docstrings and the tests. Most of my comments are very minor. The only thing I don't like is the definition of target_port with 'load' and 'source'. Any other opinions on this?

skrf/network.py Outdated Show resolved Hide resolved
skrf/network.py Outdated Show resolved Hide resolved
skrf/network.py Show resolved Hide resolved
skrf/network.py Show resolved Hide resolved
skrf/network.py Outdated Show resolved Hide resolved
@keikawa
Copy link
Contributor Author

keikawa commented Jan 15, 2024

Thank you for your kind review and comment.
As you suggested, I fixed the specification of target_port and some documentation.
Additionally, I corrected a bug where the if statement would not execute when gain_factor is ndarray.

Vinc0110
Vinc0110 approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@Vinc0110 Vinc0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. Thanks for the changes!

@Vinc0110 Vinc0110 merged commit a77612c into scikit-rf:master Jan 22, 2024
12 checks passed
@jhillairet jhillairet mentioned this pull request Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhillairet jhillairet jhillairet approved these changes

@Vinc0110 Vinc0110 Vinc0110 approved these changes

Assignees
No one assigned
Labels
Network
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stability and gain circles
3 participants
@keikawa @jhillairet @Vinc0110