Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linking issues with JS/CSS on dev #48

Closed
smangham opened this issue Jan 11, 2018 · 1 comment
Closed

Linking issues with JS/CSS on dev #48

smangham opened this issue Jan 11, 2018 · 1 comment

Comments

@smangham
Copy link
Contributor

The switch to using links to the JS/CSS rather than folding it into the file directly has unfortunately introduced some portability & sustainability issues.

It makes the saved HTML files dependent on the install directory of the module, and any environment used whilst running it- making redistributing them difficult. In addition, the HTML version is static whilst the JS/CSS is linked, potentially leading to old HTML files becoming unusable if the JS/CSS they depend on changes to require tags or elements not present in the old HTML.
@smangham smangham mentioned this issue Jan 11, 2018
Merged
@sauln
Copy link
Member

sauln commented Jan 12, 2018

Thank you for catching this!

sauln pushed a commit that referenced this issue Jan 14, 2018
Merge pull request #49 from Southampton-RSG/dev-jinja
8d76b45 
Fixing linking issues - including CSS and JS inline in html during template resolution. Fix for #48.
@sauln sauln closed this as completed Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sauln @smangham