Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples out of date #7

Closed
sauln opened this issue Sep 11, 2017 · 6 comments
Closed

Examples out of date #7

sauln opened this issue Sep 11, 2017 · 6 comments

Comments

@sauln
Copy link
Member

sauln commented Sep 11, 2017

After the API changes of v00008 some of the examples have not been updated.

These include

  • Cat
  • Horse
  • Lion
@sauln
Copy link
Member Author

sauln commented Sep 11, 2017

I've started converting the mentioned examples, but the new results are uninteresting. You can find the current output sauln/kepler-mapper@79d215c

Do you have any suggestions for making the results look more like the old style?

@MLWave
Copy link
Member

MLWave commented Sep 15, 2017

Thanks for reporting. This is in the backlog.

@sauln
Copy link
Member Author

sauln commented Sep 18, 2017

If you could provide direction, I would be happy to put in the grunt work of updating them. I've started the update but have not been able to replicate the output from the old versions.

@MLWave
Copy link
Member

MLWave commented Sep 19, 2017

I'll do one and put it here. Rest should follow from that. Thanks!

@sauln sauln closed this as completed Sep 27, 2017
@sauln
Copy link
Member Author

sauln commented Sep 27, 2017

With pull request #8, the examples fall into place and look fine. I'll create a new pull request with the updated examples once #8 is integrated.

@MLWave
Copy link
Member

MLWave commented Sep 28, 2017

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants