track names of clusters, not initial bins #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks for catching this! This got borked somewhere between earlier versions and more recent versions. I'm in the process of writing a test suite, so this won't happen again, but testing the properties of an output graph is a bit harder than I expected. If you'd like to, please add a CONTRIBUTORS file and list me: HJ van Veen info@mlwave.com, and yourself. |
|
Great! Will do. I'd gladly help add some tests. Also, I'll try to get a pull request with the updated examples done this weekend. |
|
Hi @MLWave, I tried emailing you at info@mlwave.com and it didn't go through.
Do you have another email that works? |
|
Mmmh thats weird indeed. Yeah you can contact me at henkvanveen@gmail.com |
sauln
pushed a commit
that referenced
this pull request
May 22, 2018
* Fix pep8 errors in examples/breast-cancer/breast-cancer.py * Fix pep8 errors in examples/cat/cat.py * Fix pep8 errors in examples/digits/digits.py * Fix pep8 errors in examples/horse/horse.py * Fix pep8 errors in examples/lion/lion.py * Fix pep8 errors in examples/makecircles/make_circles_distmean.py * Fix pep8 errors in examples/makecircles/make_circles_xaxis.py * Fix pep8 errors in kmapper/cover.py * Fix pep8 errors in kmapper/kmapper.py * Fix pep8 errors in kmapper/visuals.py * Fix pep8 errors in test/test_backwards.py * Fix pep8 errors in test/test_coverer.py * Fix pep8 errors in test/test_mapper.py * Fix pep8 errors in test/test_visuals.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cluster was being built for each of the overlapping bins and an edge added each time a bin overlapped.
In the one dimensional case, this created a single line.
This fix now builds nodes for each cluster and edges each time clusters share data points as Mapper is defined in the literature.