Unit tests for Allow precomputed #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* distance_matrix checks that the kmapper correctly creates a distance matrix before projecting the lens (but only for euclidean for now) * `precomputed` tests that the map function feeds the correct cube information from the X argument if argument `precompute=True` is passed. Expected to be used in conjunction with cluster function `metric='precomputed'`
|
Hello @deargle, Thank you for updating !
Comment last updated on July 18, 2018 at 07:08 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
+ Coverage 87.15% 87.58% +0.43%
==========================================
Files 6 6
Lines 436 435 -1
Branches 94 93 -1
==========================================
+ Hits 380 381 +1
+ Misses 37 36 -1
+ Partials 19 18 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add two new unit tests for lens and map: precomputed and distance_matrix
distance_matrixchecks that the kmapper correctly creates a distancematrix before projecting the lens (but only for euclidean for now)
precomputedtests that the map function feeds the correct square cubeinformation from the X argument if argument
precompute=Trueis passed.Expected to be used in conjunction with cluster function
metric='precomputed', e.g. with DBSCAN