Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs build #253

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

catanzaromj
Copy link

The documentation and build process use outdated github actions. This PR updates these and adds a dependabot to ensure they remain up-to-date moving forward.

There were changes on master that never made it into a release because these procedures were out of date. Therefore, this PR may also fix some other lingering issues as well.

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.34%. Comparing base (ece5d47) to head (ec4aaaa).

Files Patch % Lines
kmapper/visuals.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   80.32%   80.34%   +0.02%     
==========================================
  Files          11       11              
  Lines         864      865       +1     
  Branches      189      203      +14     
==========================================
+ Hits          694      695       +1     
+ Misses        138      137       -1     
- Partials       32       33       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@catanzaromj
Copy link
Author

I had to drop python 3.7 compatibility due to the way sparse matrices/arrays are handled in newer versions of scipy and numpy. Newer versions of numpy (and therefore scikit-learn) raise an error on sparse scipy matrices, in favor of sparse scipy arrays. These were not introduced until scipy 1.8.0, which requires python3.8+.

This arose from me unpnning the dependencies and updating things. Rather than keeping the dependencies pinned, I'm in favor of dropping python3.7 support (its EoL anyways). I think unpinned dependencies is better moving forward so that we stay up to date with the packages we rely on. The built and published wheels can be used for backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant