Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python versions in CI #73

Merged
merged 10 commits into from
Oct 19, 2023

Conversation

catanzaromj
Copy link
Contributor

@catanzaromj catanzaromj commented Oct 18, 2023

An attempt to modernize the CI with up-to-date python versions as described in #72.

This PR:

  • Updates the CI runners to run python 3.7 - 3.12.
  • Updates persistence images code to modern typing and their tests.
  • Fixes broken persistence landscape test.
  • Fixes broken wasserstein test.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #73 (e5e71ad) into master (c35fa04) will decrease coverage by 0.02%.
The diff coverage is 64.83%.

❗ Current head e5e71ad differs from pull request most recent head c7ee8b4. Consider uploading reports for the commit c7ee8b4 to get more accurate results

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   75.90%   75.89%   -0.02%     
==========================================
  Files          20       20              
  Lines        1457     1456       -1     
  Branches      298      315      +17     
==========================================
- Hits         1106     1105       -1     
  Misses        293      293              
  Partials       58       58              
Files Coverage Δ
persim/_version.py 100.00% <100.00%> (ø)
persim/landscapes/transformer.py 83.87% <100.00%> (ø)
persim/images.py 73.19% <62.35%> (-0.09%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@catanzaromj
Copy link
Contributor Author

@ctralie @curieux This PR is ready to be reviewed. Sorry for some extraneous changes--I run black on everything by default. I can squash some of the commits too.

@catanzaromj catanzaromj self-assigned this Oct 19, 2023
Copy link

@curieux curieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@curieux
Copy link

curieux commented Oct 19, 2023

The code coverage decreased but that's just because of line spacing I think -- not a big deal.
A followup issue should address code coverage.

@catanzaromj catanzaromj merged commit e1fb188 into scikit-tda:master Oct 19, 2023
6 checks passed
@catanzaromj catanzaromj deleted the bring-ci-to-3.12 branch October 23, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants