Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate bundle/recognize module to scilpy 2.0.0 + nf-test #134

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

gagnonanthony
Copy link
Contributor

@gagnonanthony gagnonanthony commented Apr 24, 2024

Type of improvement

If submitting a new module or fixing a bug, please use the appropriate template.

  • Documentation
  • Development tools (e.g. linter, formatter, etc.)
  • Development container
  • Global update (please specify)
  • Other (please specify)

Describe your improvement

Update module bundle/recognize to match the new scilpy (2.0.0) and update test to the nf-test framework.

Checklist before requesting a review

  • Ensure the syntax is correct (EditorConfig and Prettier must pass)
  • Run the test suites if your changes affect any module
  • Regenerate the Poetry lock file if you have updated the dependencies
  • Ensure the documentation is up-to-date

#79 #114

@gagnonanthony gagnonanthony added the enhancement New feature or request label Apr 24, 2024
@gagnonanthony gagnonanthony changed the title [WIP] Migrate bundle/recognize module to scilpy 2.0.0 + nf-test Migrate bundle/recognize module to scilpy 2.0.0 + nf-test Apr 24, 2024
@AlexVCaron AlexVCaron mentioned this pull request Apr 25, 2024
Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@AlexVCaron AlexVCaron merged commit 685f84d into scilus:main Apr 29, 2024
9 checks passed
@gagnonanthony gagnonanthony deleted the bundle_scilpy2.0 branch April 30, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants