[FIX] Empty remaining indices when filtering for a bundle #1002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick description
When using the _extract_vb_and_wpc_all_bundles function from the file
tractogram_from_roi.py
, there's a loop that updates and uses the remaining_ids list. While iterating over the bundles, it is possible that the list of remaining indices becomes empty thus creating an empty StatefulTractogram. This was causing some issues with the sub-functionfilter_grid_roi_both
which internally was trying to transpose an empty matrix, which is invalid.I added a quick check and some simple tests to make sure the sft provided as an input is not empty before filtering the streamlines w.r.t. the ROI.
Type of change
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
pytest scilpy/segment/tests/test_tractogram_from_roi.py
Checklist