Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: tractogram add dps #1006

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AntoineTheb
Copy link
Contributor

@AntoineTheb AntoineTheb commented Jun 25, 2024

Quick description

New script to add data per streamline to a tractogram. Can be colors, streamline ids, sift2 weights, bundle names; your imagination is the only limit.

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Data

https://drive.google.com/file/d/1lagozFxH6k4U8TvaX49e6_sPWj3CptyG/view?usp=sharing

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@AntoineTheb AntoineTheb marked this pull request as draft June 25, 2024 13:10
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.38%. Comparing base (920ec63) to head (f3bbe90).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1006      +/-   ##
==========================================
+ Coverage   68.34%   68.38%   +0.03%     
==========================================
  Files         420      421       +1     
  Lines       21441    21471      +30     
  Branches     3215     3217       +2     
==========================================
+ Hits        14654    14682      +28     
- Misses       5527     5528       +1     
- Partials     1260     1261       +1     
Components Coverage Δ
Scripts 69.35% <100.00%> (+0.05%) ⬆️
Library 66.96% <ø> (ø)

@AntoineTheb AntoineTheb self-assigned this Jun 26, 2024
@AntoineTheb AntoineTheb marked this pull request as ready for review June 26, 2024 12:50
@AntoineTheb AntoineTheb changed the title WIP: tractogram add dps ENH: tractogram add dps Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant