Remove invalid streamlines (out of bbox) #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeTh
approved these changes
Aug 21, 2019
added 2 commits
August 22, 2019 10:20
|
@frheault can you merge the master and do some fixing before I review ? I already noticed the |
added 2 commits
September 16, 2019 16:38
arnaudbore
approved these changes
Sep 17, 2019
jchoude
reviewed
Sep 18, 2019
| DESCRIPTION = """ | ||
| Removal of streamlines that are out of the volume bounding box. In voxel space | ||
| no negative coordinate and no above volume dimension coordinate are possible. | ||
| Any streamlines that do not respect these two conditions are removed. |
| @@ -23,7 +23,8 @@ def load_tractogram_with_reference(parser, args, filepath, | |||
| bbox_check=True): | |||
| _, ext = os.path.splitext(filepath) | |||
| if ext == '.trk': | |||
| sft = load_tractogram(filepath, 'same') | |||
| sft = load_tractogram(filepath, 'same', | |||
There was a problem hiding this comment.
This function should probably go in scilpy.io.streamlines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New scripts to remove streamlines that are invalid in vox space