Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add angle coloring option + fix bugs #718

Merged
merged 1 commit into from
May 17, 2023

Conversation

EmmaRenauld
Copy link
Contributor

Added an option to color a tractogram based on the local angle of the streamline. Particularly nice on smoothed streamlines.

+ Fixed bugs in script, where options min_range, max_range, etc. were not used with option --along_profile (and thus lbound, ubound variables did not always exist).

+ Added more ticks on the colorbar (previously only the min and max values were shown).

+ Added the possibility to show the colorbar right away. It is the last step of the script so even if user closes the window, everything is done and saved.

image
image

@arnaudbore arnaudbore self-requested a review May 10, 2023 18:45
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice

@arnaudbore arnaudbore merged commit 233bb50 into scilus:master May 17, 2023
5 checks passed
@EmmaRenauld EmmaRenauld deleted the color_per_angle branch May 17, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants