Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verifications in volume_resample #986

Merged
merged 4 commits into from Apr 26, 2024

Conversation

EmmaRenauld
Copy link
Contributor

Reverted recent change in scil_volume_resample, that input image and ref had to be compatible: not here! Ref is the reference to which to reshape.

  • Added a test in the script test to use the --ref option.
  • Added tests in the the unit test for all options in volume_resample
  • Fixed option names in function resample_volume: arg res meant: the final shape of the image. Usually, resolution is the voxel shape! Renamed.

@pep8speaks
Copy link

pep8speaks commented Apr 26, 2024

Hello @EmmaRenauld, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-04-26 19:05:40 UTC

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 68.07%. Comparing base (9b79ea4) to head (3452087).
Report is 5 commits behind head on master.

❗ Current head 3452087 differs from pull request most recent head 78fbd20. Consider uploading reports for the commit 78fbd20 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #986      +/-   ##
==========================================
+ Coverage   68.01%   68.07%   +0.06%     
==========================================
  Files         419      419              
  Lines       21567    21577      +10     
  Branches     3241     3245       +4     
==========================================
+ Hits        14668    14688      +20     
+ Misses       5608     5601       -7     
+ Partials     1291     1288       -3     
Components Coverage Δ
Scripts 68.96% <71.42%> (-0.01%) ⬇️
Library 66.72% <47.36%> (+0.15%) ⬆️

Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

Copy link
Contributor

@karanphil karanphil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (just 2 small comments)

scilpy/image/volume_operations.py Outdated Show resolved Hide resolved
scripts/scil_volume_resample.py Outdated Show resolved Hide resolved
@arnaudbore arnaudbore merged commit 876c584 into scilus:master Apr 26, 2024
1 check passed
@EmmaRenauld EmmaRenauld deleted the fix_verifications_resample branch April 26, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants