Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update COMMIT AMICO - use args.processes #998

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

arnaudbore
Copy link
Contributor

@arnaudbore arnaudbore commented Jun 10, 2024

Quick description

Since last version we are able to choose the number of threads used to compute NODDI and COMMIT.
We were not using it. Now we use args.processes

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@arnaudbore arnaudbore changed the title first test using args.processes Update COMMIT AMICO - use args.processes Jun 10, 2024
@pep8speaks
Copy link

pep8speaks commented Jun 11, 2024

Hello @arnaudbore, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-06-29 14:54:40 UTC

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.35%. Comparing base (17b9a4a) to head (699deef).
Report is 44 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #998      +/-   ##
==========================================
+ Coverage   68.14%   68.35%   +0.20%     
==========================================
  Files         419      420       +1     
  Lines       21369    21444      +75     
  Branches     3216     3215       -1     
==========================================
+ Hits        14561    14657      +96     
+ Misses       5533     5527       -6     
+ Partials     1275     1260      -15     
Components Coverage Δ
Scripts 69.30% <100.00%> (+0.16%) ⬆️
Library 66.96% <ø> (+0.29%) ⬆️

@@ -39,9 +40,9 @@ pytz==2022.6.*
requests==2.28.*
scikit-learn==1.2.*
scikit-image==0.22.*
scipy==1.9.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're changing versions...

Here's what I had to change to be able to use scilpy on Beluga. Can we put scipy 1.11?

image

Copy link
Contributor

@EmmaRenauld EmmaRenauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test, but looks ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants