Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multi-stage build copying dependencies from separately built image #208

Merged
merged 11 commits into from
Apr 25, 2024

Conversation

manning-ncsa
Copy link
Collaborator

@manning-ncsa manning-ncsa commented Apr 24, 2024

Related to #207.

Description of the Change

Use multi-stage build that copies dependencies from a separately built image that will rarely change.

@manning-ncsa manning-ncsa self-assigned this Apr 24, 2024
@manning-ncsa manning-ncsa marked this pull request as ready for review April 25, 2024 15:49
@manning-ncsa
Copy link
Collaborator Author

This PR includes some changes not directly related to the multi-stage build:

  • The unit tests have been removed from the CI workflow until Fix the broken CI workflow that runs the unit tests #207 is resolved. @djones1040 and I decided that until then, the unit tests must be manually run locally before merging a pull request to main.
  • The local Docker Compose config files and wrapper scripts were refactored to properly target the different deployment profiles, where previously for example, the "ci" profile was actually including the .env.dev environment file, which could in general invalidate the results of the unit tests.

@manning-ncsa manning-ncsa merged commit 059ec6b into main Apr 25, 2024
3 of 4 checks passed
@manning-ncsa manning-ncsa deleted the ci-workflow branch April 25, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant