Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Go 1.13 #3349

Closed
scrye opened this issue Nov 8, 2019 · 1 comment · Fixed by #3362
Closed

Upgrade to Go 1.13 #3349

scrye opened this issue Nov 8, 2019 · 1 comment · Fixed by #3362
Assignees
@lukedirtwalker
Labels
feature New feature or request i/devops Everything related to CI/Bazel/building

Comments

@scrye
Copy link
Contributor

scrye commented Nov 8, 2019

We should upgrade to the latest version of Go.

#3009 might be a blocker, we'll need to investigate.
@scrye scrye added i/devops Everything related to CI/Bazel/building feature New feature or request labels Nov 8, 2019
@scrye scrye added this to the Q4S3 milestone Nov 8, 2019
@scrye
Copy link
Contributor Author

scrye commented Nov 11, 2019

After upgrading, all tests should still pass.

@scrye scrye removed this from the Q4S3.D milestone Nov 12, 2019
@lukedirtwalker lukedirtwalker self-assigned this Nov 13, 2019
lukedirtwalker added a commit to lukedirtwalker/scion that referenced this issue Nov 13, 2019
@lukedirtwalker
Upgrade to go1.13
0f85368 
This is also requires an upgrade of GoConvey

Fixes scionproto#3349
Fixes scionproto#3009
@lukedirtwalker lukedirtwalker mentioned this issue Nov 13, 2019
Merged
lukedirtwalker added a commit to lukedirtwalker/scion that referenced this issue Nov 18, 2019
@lukedirtwalker
Upgrade to go1.13
fb71ea8 
This is also requires an upgrade of GoConvey

Fixes scionproto#3349
Fixes scionproto#3009
lukedirtwalker added a commit that referenced this issue Nov 18, 2019
@lukedirtwalker
Upgrade to Go 1.13 (#3362)
b9e0f86 
This also upgrades the GoConvey dependency as it is required for Go 1.13.

Fixes #3349
Fixes #3009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukedirtwalker lukedirtwalker

Labels
feature New feature or request i/devops Everything related to CI/Bazel/building
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to Go 1.13 lukedirtwalker/scion
2 participants
@lukedirtwalker @scrye