Remove c/

[lukedirtwalker]

As explained in #3140 it is no longer worth maintaining those.

Fixes #3140

---

This change is 

[kormat]

Reviewed 2 of 41 files at r1.
Reviewable status: 2 of 41 files reviewed, 3 unresolved discussions (waiting on @lukedirtwalker)

a discussion (no related file):
zlog should be dropped too. It was only ever used by the C code. Same probably goes for some things in env/debian/pkgs.txt. ./docker.sh scion_base && ./docker.sh scion should allow you to check what's no longer needed.

---

---

Makefile, line 36 at r1 (raw file):

# as those aren't created by bazel.
bazel_bin_clean:
	find bin/ -mindepth 1 ! -iname ".*" -exec rm {} +

This becomes rm -f bin/*

---

docker/perapp/app/Dockerfile.dispatcher, line 1 at r1 (raw file):

FROM scion_app_base:latest

There's a mention of this in perapp/README.md

[lukedirtwalker]

Reviewable status: 2 of 41 files reviewed, 3 unresolved discussions (waiting on @kormat)

a discussion (no related file):

Previously, kormat (Stephen Shirley) wrote…

zlog should be dropped too. It was only ever used by the C code. Same probably goes for some things in env/debian/pkgs.txt. ./docker.sh scion_base && ./docker.sh scion should allow you to check what's no longer needed.

Done.

---

---

Makefile, line 36 at r1 (raw file):

Previously, kormat (Stephen Shirley) wrote…

This becomes rm -f bin/*

Done.

---

docker/perapp/app/Dockerfile.dispatcher, line 1 at r1 (raw file):

Previously, kormat (Stephen Shirley) wrote…

There's a mention of this in perapp/README.md

Done. That README is out of date anyways

[kormat]

Reviewed 38 of 41 files at r1.
Reviewable status: 40 of 41 files reviewed, 2 unresolved discussions (waiting on @kormat)

[kormat]

Reviewed 12 of 12 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker)

---

Makefile, line 35 at r2 (raw file):

# Delete everything in bin/ that isn't a hidden file,
# as those aren't created by bazel.
bazel_bin_clean:

As this isn't really bazel-specific anymore, i'd rename it to clean_bin, and have the clean target depend on it.

---

docker/perapp/app/Dockerfile.dispatcher, line 1 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

Done. That README is out of date anyways

The change isn't visible in this PR.

[lukedirtwalker]

Reviewable status: 49 of 51 files reviewed, 2 unresolved discussions (waiting on @kormat)

---

Makefile, line 35 at r2 (raw file):

Previously, kormat (Stephen Shirley) wrote…

As this isn't really bazel-specific anymore, i'd rename it to clean_bin, and have the clean target depend on it.

Done.

---

docker/perapp/app/Dockerfile.dispatcher, line 1 at r1 (raw file):

Previously, kormat (Stephen Shirley) wrote…

The change isn't visible in this PR.

Done.

[kormat]

Reviewed 2 of 2 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)

---

Makefile, line 9 at r3 (raw file):

all: tags bazel

clean: clean_bin

Drop clean_bin.

[lukedirtwalker]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kormat)

---

Makefile, line 9 at r3 (raw file):

Previously, kormat (Stephen Shirley) wrote…

Drop clean_bin.

Done.

[kormat]

Reviewed 2 of 2 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved