Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scipion-gui.rst #55

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Update scipion-gui.rst #55

merged 2 commits into from
Oct 14, 2022

Conversation

brodriguezdefrancisco
Copy link
Collaborator

No description provided.

@brodriguezdefrancisco brodriguezdefrancisco marked this pull request as ready for review October 6, 2022 14:02
@brodriguezdefrancisco
Copy link
Collaborator Author

brodriguezdefrancisco commented Oct 6, 2022

TO DO. “Queue” and “wait for” modifications

image

It is confusing how queue and wait for work.

Should be in a separate level:

image

I would change "Use queue" to “Use engine queuing system?”
change "wait for" to “Schedule protocol after”

"Queue interrogation mark" modify to:

Click Yes if you want to submit a single job per protocol to a batch-queuing system.
The queue commands to launch and stop jobs should be configured
for the current host in the /home/tomo/Software/scipion3/config/hosts.conf file.

“wait for” interrogation mark modify to:

Specify a comma separated list of protocol IDs if you want
that this protocol starts after the input protocols in the list
are finished. This function will allow you to "schedule" many
runs that will be executed after each other.

@pconesa
Copy link
Contributor

pconesa commented Oct 14, 2022

Hi @brodriguezdefrancisco , the help for "wait for" it is actually the same as we have. there is no change. Is that correct?

https://github.com/scipion-em/scipion-pyworkflow/blob/devel/pyworkflow/utils/properties.py#L171

@brodriguezdefrancisco
Copy link
Collaborator Author

Hi @brodriguezdefrancisco , the help for "wait for" it is actually the same as we have. there is no change. Is that correct?

https://github.com/scipion-em/scipion-pyworkflow/blob/devel/pyworkflow/utils/properties.py#L171

That is correct. I couldn´t find any better way to say/explain it

@pconesa
Copy link
Contributor

pconesa commented Oct 14, 2022

What about this:

Specify a comma separated list of protocol IDs if you want
to schedule this protocol and wait for those protocols to finish before
starting this one. This function will allow you to "schedule" many
runs that will be executed after each other. For more information see https://scipion-em.github.io/docs/release-3.0.0/docs/user/scipion-gui.html#waiting-for-other-protocols

@pconesa
Copy link
Contributor

pconesa commented Oct 14, 2022

Relocating the elements in the form is possible but will take more time.

This is my suggestion bsaed on yours:
image

image

@brodriguezdefrancisco
Copy link
Collaborator Author

I thing it is good. I would change "runs" for "tasks". Sometimes I get confused with "protocols" because it has a sense of list of things, but it is a personal view (and it is in all workflows and difficult to change).

@brodriguezdefrancisco
Copy link
Collaborator Author

very nice Pablo 👍

@pconesa
Copy link
Contributor

pconesa commented Oct 14, 2022

Yes, I kind of agree, buy "protocol" is all over the place.

@pconesa
Copy link
Contributor

pconesa commented Oct 14, 2022

Thanks @brodriguezdefrancisco for improving Scipion and it's documentation.

@pconesa pconesa merged commit 364fe1b into release-3.0.0 Oct 14, 2022
@pconesa pconesa deleted the wait-for-and-queu branch October 14, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants