Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix to euler angles is not stable around sphere poles #148

Open
MohamadHarastani opened this issue Dec 26, 2022 · 0 comments
Open

Matrix to euler angles is not stable around sphere poles #148

MohamadHarastani opened this issue Dec 26, 2022 · 0 comments
Assignees

Comments

@MohamadHarastani
Copy link
Collaborator

FYI:
This matrix https://github.com/scipion-em/scipion-em-continuousflex/blob/master/continuousflex/protocols/utilities/dynamo.py#L40 is not stable. It is used multiple times in continuousflex. It is correct in most of the situations but not around the poles (zero angles and opposite to it).

The usage of this matrix should be replaced by
from pwem.convert.transformations import (translation_from_matrix, euler_from_matrix)

A usage example is here
https://github.com/I2PC/scipion-em-xmipp/blob/devel/xmipp3/convert/convert.py#L1339

Whenever you are working on convert a transformation matrix to euler angles try to use the new function

Mohamad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants