fix csh installation with conda #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is fantastic @azazellochg . |
|
I'm not following.. why do we need it?or just for csh? |
|
I think adding it will make installation more difficult for users, they dont need to know about this. |
|
I mean, storing it. The installer already knows how to activate conda. Why
not storing it? Maybe the same logic can go into pyworkflow to
automatically come up with a valid conda initialization without asking the
user.
El dom., 1 nov. 2020 19:25, Grigory Sharov <notifications@github.com>
escribió:
… I think adding it will make installation more difficult for users, they
dont need to know about this.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAF7ZYKDL444O3S4WLNIJBLSNWR25ANCNFSM4TGRD3GA>
.
|
|
So,what this fixes is the installation on a system with csh/tcsh shell. But I guess now, the issue is moved to activating "conda based" binaries (cryolo, topaz, fsd3d, ....)? Or will "conda activate something" work? |
|
I'll need to install xmipp and cryolo to test
Best regards,
Grigory
…--------------------------------------------------------------------------------
Grigory Sharov, Ph.D.
MRC Laboratory of Molecular Biology,
Francis Crick Avenue,
Cambridge Biomedical Campus,
Cambridge CB2 0QH, UK.
tel. +44 (0) 1223 267228 <+44%201223%20267228>
e-mail: gsharov@mrc-lmb.cam.ac.uk
On Tue, Nov 3, 2020 at 7:55 AM Pablo Conesa ***@***.***> wrote:
So,what this fixes is the installation on a system with csh/tcsh shell.
But I guess now, the issue is moved to activating "conda based" binaries
(cryolo, topaz, fsd3d, ....)? Or will "conda activate something" work?
@azazellochg <https://github.com/azazellochg> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBPJXJBERUROSCD5TCFL3SN6ZQLANCNFSM4TGRD3GA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a few hours I was able to install scipion via miniconda in a user account with tcsh as default shell. The problem with csh that conda functions are not exported to the subshells (in our case /bin/sh invoked by os.system). See conda/conda#7980
This closes #19
Other csh issues like Illegal variable or syntax error were fixed since conda 4.7.x