-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sprites #490
Sprites #490
Conversation
users: - New Icons. - Icons based on sprites, easier to resize or customized - New variable: SCIPION_SPRITES_FILE to point to a custom sprite. It should be compatible with sprites.png at pyworkflow/resources. - Scipion GUI log moved to the log tabs and removed from menu - New variable: SCIPION_SHOW_TEXT_IN_TOOLBAR, set it to anything to show the text of the icons below developers: - ProjectConfig class removed - New methods in path: hasChangedSince and isFileFinished - New method in utils: strToDuration (useful to translate "1h 35m" to seconds). For duration parameters. - New class Variable to be tested in Config class. A step towards a Config editing GUI. - SCIPION_DEBUG_SQLITE rescued to activate SQL clauses in debug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, sprites are a 32 pixel size that is too much.... I plan to make them back to 16 with a "zoom" parameter at 50% then will be back to normal. In case someone wants a bigger zoom then this may appear... unless we find a way to make trees respond to icon sizes. I failed so far. |
@plosana will work on the other icons still to change. Once ready this can be merge. I change it to draft for now |
Since you are working on this, could we please change the order of buttons? It takes me 5 seconds to find the stop protocol or browse button. The most used buttons should go first. |
<!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 3.0cm 70.85pt 3.0cm;}
div.WordSection1
{page:WordSection1;}
-->That is not a common practice… most software group icons by “similar functionality”, may be the problema is tha icons are not enough? You alway have the resourc of learning the shortcuts!! 😉 We are far from customizing the order… not sure if we Will do it, but thanks, I’ll make a note….. what others (Reading this) think about this?. De: Grigory SharovEnviado: miércoles, 10 de enero de 2024 13:09Para: scipion-em/scipion-pyworkflowCC: Pablo Conesa; AuthorAsunto: Re: [scipion-em/scipion-pyworkflow] Sprites (PR #490) Since you are working on this, could we please change the order of buttons? It takes me 5 seconds to find the stop protocol or browse button. The most used buttons should go first.—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Patricia,
You are using nicer icons in your proposal screenshot, so biasing us toward
it. ;)
In any grouping, I suggest briefly asking some users and hiding some icons
for actions that are not used that frequently. (in my opinion, for example:
labels, workflow selected, etc)
Best,
Jose Miguel
…On Wed, Jan 10, 2024 at 9:27 AM Patricia Losana ***@***.***> wrote:
Hi everyone! I agree with Grigory that I find more intuitive a different
order for the icons. I did a bit of a study grouping the icons by the
functionality that they had and came up with this:
image.png (view on web)
<https://github.com/scipion-em/scipion-pyworkflow/assets/8470316/488713ae-88ea-49b9-9eec-2d19f05ff9bd>
To me, a more intuitive order would be the one I propose below, but any
ideas are welcome :)
image.png (view on web)
<https://github.com/scipion-em/scipion-pyworkflow/assets/8470316/0972fb54-bf37-4aa8-b1bf-e4ba1bf5ec56>
—
Reply to this email directly, view it on GitHub
<#490 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACAM6WB5AIC44GPSDJ7XBH3YN2XNDAVCNFSM6AAAAABBUQ6AKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBVGA3DGOBYGU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
…ns at 24x24. 100 will set them to 32 or 50 to 16.
@plosana that looks beautiful! Labels are definitely helpful, otherwise I often have to hover over every button to find the meaning 😁 |
There is a variable to Show or not the labels. Do we want it active by default? |
Yes please 🥺 |
Yes!! I believe it would be very very helpful |
After the last changes, it looks nice! I've checked all the windows with icons and they all behave well in terms of appearance. My only question is regarding the "Browse" window, if the last two options of the toolbar ("Recent" and "Protocol folder") not have an associated icon, or it is not being displayed properly. |
On the other hand, I had some execution problems when using this branch. Here's an example: 00001: Traceback (most recent call last): |
Thanks JOrge, I think we need to overload more methods of the Variable class. I'll fix it |
Those "actions" never had an icon. |
Haha, my bad! Sorry |
If you pull latest changes there should be no error with the plugin now. |
Solved! Thanks |
Scan folders without a fixed depth
|
users: