Step queue executor: fix stop protocol action #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and clean jobids and pid when needed
danielmarchan3
added
bug
pconesa
requested changes
Feb 28, 2024
Of course, it is done. |
pconesa
approved these changes
Feb 29, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved handling of the case where we send protocols steps to the queue:
Previously, stopping the protocol did not effectively prevent it from sending jobs to the queue. Now, active jobs are stored in the 'jobIds' protocol variable. Iteration through these job IDs allows for canceling each active job sent to the queue. After cancellation, the parent process controlling the protocol and its child processes are terminated.
Implemented cleaning of old protocol job IDs and PIDs. This cleaning occurs when duplicating, resetting, or restarting a protocol. Previously, these values were maintained even though they were not active.