Mcstas instrument parser and data loader. #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YooSunYoung
force-pushed
the
mcstas-instrument-parser
branch
2 times, most recently
from
91225d3
to
5e9bf77
Compare
YooSunYoung
force-pushed
the
dependency-update
branch
from
eb44a0c
to
ba72291
Compare
@Justin-Bergmann |
|
Unfortunately it does not look right, it should look like a box with only three sides. We can next year look together at it |
How about the source position and sample position...? |
11 tasks
YooSunYoung
force-pushed
the
mcstas-instrument-parser
branch
from
d15c317
to
e36a6ef
Compare
|
Closing this in favor of #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
Data loader now load geometry coordinates as well by parsing instrument geometry xml in the McStas file.\
TODO: