Add sc.zeros_like and sc.ones_like functions
#1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, was not ready, forgot to mark as draft, sorry |
SimonHeybrock
approved these changes
Apr 26, 2021
jl-wynen
reviewed
Apr 26, 2021
There was a problem hiding this comment.
it would be useful if the user could overwrite individual arguments. I often use np.zeros_like to get an array with the same dtype but different shape as something else. Since in scipp, we have more parameters, this might be even more useful to, e.g., change only the unit.
Agree, but we can add that later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.