Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plotting with masks in presence of multi-dim coords #2269

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Fix plotting with masks in presence of multi-dim coords #2269

merged 1 commit into from
Nov 9, 2021

Conversation

SimonHeybrock
Copy link
Member

Fixes #2212.

Yet another special case. Our lives might be much simpler without resampling?

nvaytet
nvaytet approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@nvaytet nvaytet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a special case indeed 👍

@SimonHeybrock
Copy link
Member Author

Not so special actually (with scippneutron). I believe this happens if you simply mask, e.g., a time-of-flight range, then convert to wavelength.

@SimonHeybrock SimonHeybrock merged commit 696dac1 into main Nov 9, 2021
@SimonHeybrock SimonHeybrock deleted the multi-dim-coord-mask-plot branch November 9, 2021 14:18
@nvaytet
Copy link
Member

nvaytet commented Nov 9, 2021

The long if statement made it look extra special tough ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvaytet nvaytet nvaytet approved these changes

Assignees
No one assigned
Labels
bug visualization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plotting with multi dimensional array and mask can fail
2 participants
@SimonHeybrock @nvaytet