Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify PR policies to reflect need to merge 2018 back into dev #381

Closed
mpacer opened this issue May 13, 2018 · 1 comment
Closed

Modify PR policies to reflect need to merge 2018 back into dev #381

mpacer opened this issue May 13, 2018 · 1 comment

Comments

@mpacer
Copy link
Contributor

mpacer commented May 13, 2018

If people have PRs that start out against 2018 and switched to be pulled into dev, they will include the merge commits from dev to 2018, which looks odd.

We should make it part of our procedure to merge 2018 back into dev so the merge from dev to 2018 is included in master.

I don't know another way to do this without asking people to rebase their branches onto dev.

So we should update the instructions to reflect that.

@deniederhut
Copy link
Member

I'm not sure this is a problem any more. Closing unless you have objections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants