Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paper: geosnap: The Geospatial Neighborhood Analysis Package #931

Open
wants to merge 6 commits into
base: 2024
Choose a base branch
from

Conversation

knaaptime
Copy link

@knaaptime knaaptime commented Jun 1, 2024

Editor: Amey Ambade @ameyxd

Reviewers:

@cbcunc cbcunc changed the title init Paper: init Jun 1, 2024
@cbcunc cbcunc added the paper This indicates that the PR in question is a paper label Jun 1, 2024
@knaaptime knaaptime changed the title Paper: init Paper: introducing geosnap Jun 3, 2024
Copy link

github-actions bot commented Jun 3, 2024

Curvenote Preview

Directory Preview Checks Updated (UTC)
papers/eli_knaap 🔍 Inspect 80 checks passed (7 optional) Jun 12, 2024, 8:20 PM

@hongsupshin
Copy link
Contributor

@knaaptime Hi Eli, could you update the PR name so that it reflects the title of the paper? This would avoid any confusion during the review process. Thanks!

@knaaptime
Copy link
Author

sorry, yes! making some updates shortly

@ameyxd
Copy link
Contributor

ameyxd commented Jun 4, 2024

@knaaptime can you update the DOIs and link that fail checks?

@ameyxd ameyxd self-assigned this Jun 4, 2024
@knaaptime
Copy link
Author

yes! I also need to add several abbreviations to the yaml. Can I add a wip tag for a day or two?

@ameyxd
Copy link
Contributor

ameyxd commented Jun 6, 2024

@knaaptime issue here also affects your paper. We are working on a fix.

@knaaptime knaaptime changed the title Paper: introducing geosnap Paper: geosnap: The Geospatial Neighborhood Analysis Package Jun 7, 2024
@ameyxd ameyxd removed their assignment Jun 11, 2024
@ameyxd
Copy link
Contributor

ameyxd commented Jun 11, 2024

@knaaptime there are some citations that do not have DOIs. can you recheck the DOIs that fail checks? As long as they are valid DOIs we should be okay.

you may be able to add citation keys you want to ignore if their DOIs don't exist in myst.yml under error_rules:

  - rule: doi-exists
    severity: ignore
    keys:
      - abc
      - def01

@knaaptime
Copy link
Author

pushed a fix for two articles that are missing. Not sure whats up with he rest of those 'doi fail to resolve' errors. If you click the link shown in the CI it will take you right to the article

@rowanc1
Copy link
Contributor

rowanc1 commented Jun 11, 2024

Hi @knaaptime -- we are having some issues with doi.org at the moment (see #935), we should have this fixed by the end of the week. Thank you for adding DOIs, we will get the other checks passing soon!

papers/eli_knaap/main.md Outdated Show resolved Hide resolved
Co-authored-by: Franklin Koch <franklin@curvenote.com>
@fwkoch
Copy link
Collaborator

fwkoch commented Jun 12, 2024

Thanks for merging that suggestion - the previous failure is now fixed. The new failure is back to another, different DOI issue on the checks 🙁. Fixing it up now, nothing more for you to worry about 🙂.

temporal analyses. That is, unlike the original decennial census data whose polygons are
different in each time period, the harmonized data can be used directly in studies of
neighborhood change, for example those using Markov-based methods [@Agovino2019; @gallo_space-time_2004-1; @kang_rey_2018_ars; @rey_2016_jgs; @Rey2014] or
sequence-analysis methods [@Kang2020a; @Lee2017] (both of which are built into `geosnap`)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this Kang2020a citation does not have a corresponding entry in your bib file, so it does not resolve:

image

Can you add an entry for this?

@ameyxd
Copy link
Contributor

ameyxd commented Jun 20, 2024

Review requests sent to @shuangw1 and @shahnawaz323

@ameyxd
Copy link
Contributor

ameyxd commented Jul 2, 2024

Resent email requests for review to @shuangw1 and @shahnawaz323

@shuangw1
Copy link

shuangw1 commented Jul 2, 2024 via email

@cbcunc cbcunc requested a review from stargaser July 10, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paper This indicates that the PR in question is a paper ready-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants