Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: asv benchmark failed because of cython version #11951

Closed
AtsushiSakai opened this issue Apr 27, 2020 · 4 comments
Closed

BUG: asv benchmark failed because of cython version #11951

AtsushiSakai opened this issue Apr 27, 2020 · 4 comments
Labels
Benchmarks Running, verifying or documenting benchmarks for SciPy Cython Issues with the internal Cython code base
Milestone

Comments

@AtsushiSakai
Copy link
Member

AtsushiSakai commented Apr 27, 2020

My issue is about ...

When I run asv benchmark with

$ python3 runtests.py --bench-compare master [benchmark]

The following error happened:

File "/home/scipy/benchmarks/env/50b24b3c8780d96e0e45210808587953/project/tools/cythonize.py", line 81, in process_pyx
'{}'.format(required_version, cython_version))
Exception: Building SciPy requires Cython >= 0.29.14, found 0.29.13

I think this is because pyproject.toml needs:

"Cython>=0.29.14",

But, asv is using:
"Cython": ["0.29.13"],

When I changed the cython version to 0.28.14 in asv.conf.json, it works.

Scipy/Numpy/Python version information:

Current master code.

@miladsade96 miladsade96 added Benchmarks Running, verifying or documenting benchmarks for SciPy Cython Issues with the internal Cython code base labels Apr 27, 2020
rgommers added a commit to rgommers/scipy that referenced this issue Apr 27, 2020
@rgommers
Copy link
Member

Thanks, fixed in commit cd56e79

@rgommers rgommers added this to the 1.5.0 milestone Apr 27, 2020
@AtsushiSakai
Copy link
Member Author

AtsushiSakai commented Apr 27, 2020

@rgommers I think "toolchain.rst" should be also updated too if you didn't it:
SS 2020-04-27 at 23 14 13

@rgommers
Copy link
Member

Indeed. That requires some other updates as well (like for C++11/14), I'll open a PR.

@rgommers
Copy link
Member

Done in gh-11952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmarks Running, verifying or documenting benchmarks for SciPy Cython Issues with the internal Cython code base
Projects
None yet
Development

No branches or pull requests

3 participants