Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BENCH: fix disabled (broken) benchmarks #19389

Open
4 tasks
j-bowhay opened this issue Oct 15, 2023 · 1 comment
Open
4 tasks

BENCH: fix disabled (broken) benchmarks #19389

j-bowhay opened this issue Oct 15, 2023 · 1 comment
Labels
Benchmarks Running, verifying or documenting benchmarks for SciPy good first issue Good topic for first contributor pull requests, with a relatively straightforward solution maintenance Items related to regular maintenance tasks task A straightforward change, verification or fix.

Comments

@j-bowhay
Copy link
Member

j-bowhay commented Oct 15, 2023 •
edited

In #19052 some broken benchmarks were disabled:

It would be nice to fix these. Time allowing, I hope to update this issue with a tracker containing all the disabled benchmarks. However, for now, this serves as a reminder, and there is nothing to stop anyone from working on this immediately.

cc @h-vetinari
@j-bowhay j-bowhay added good first issue Good topic for first contributor pull requests, with a relatively straightforward solution maintenance Items related to regular maintenance tasks Benchmarks Running, verifying or documenting benchmarks for SciPy labels Oct 15, 2023
@Saswatsusmoy Saswatsusmoy mentioned this issue Oct 17, 2023
Open
Saswatsusmoy added a commit to Saswatsusmoy/scipy that referenced this issue Oct 20, 2023
@Saswatsusmoy
Merge branch 'scipy:main' into Saswatsusmoy-scipy#19389-BENCH-fix-dis…
b4c9bda 
…abled-(broken)-benchmarks
rgommers added a commit to HaoZeke/scipy that referenced this issue Apr 25, 2024
@rgommers
BENCH: disable very slow benchmark in optimize_milp.py
ebd1bc9 
This was no slower after the update to HiGHS (verified locally) in
PR 19255. However it takes very long to run and was already near the
limit for CircleCI. The tracking issue for this already existed
as well: scipy#19389

[skip actions] [skip cirrus]
@rgommers rgommers mentioned this issue Apr 25, 2024
Merged
6 tasks
@j-bowhay j-bowhay added the task A straightforward change, verification or fix. label Apr 25, 2024
@rgommers
Copy link
Member

Disabling another benchmark in optimize_milp.py in #19255 (comment). And commented on gh-19401, which is an attempt at solving this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Benchmarks Running, verifying or documenting benchmarks for SciPy good first issue Good topic for first contributor pull requests, with a relatively straightforward solution maintenance Items related to regular maintenance tasks task A straightforward change, verification or fix.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgommers @j-bowhay