Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BENCH: update asv, fail benchmark CI on errors, fix fallout #19052

Merged
merged 7 commits into from Aug 24, 2023

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Aug 12, 2023

Rebased #18857 + trying to debug.

Towards #18860 (done in #19104)
Closes #18868
Closes #18849

@h-vetinari
Copy link
Member Author

Hey all, the benchmarks are currently broken (as in: several of them fail silently), and have been for a good two years at least (that's when wminkowski was removed, it was still being called in the benchmarks).

I've tried to skip the failures here (with the exception of those added in 3c54130, I think they never passed. I asked the author to take a look in #18860, but haven't heard back yet). I don't expect this to be mergeable as is, but wanted to discuss how we can get to a point where we can unbreak this.

BTW, this also solves the current asv-pin. Key insight (from @HaoZeke in #18857, which this PR rebases) is that we need to pass --quick to get the pre-0.5 behaviour. There've been other asv improvements; currently this uses a development version, but a new asv-release is apparently not too far away according to @HaoZeke,

@h-vetinari h-vetinari added Benchmarks Running, verifying or documenting benchmarks for SciPy CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure DX Everything related to making the experience of working on SciPy more pleasant labels Aug 15, 2023
@j-bowhay
Copy link
Member

I am happy with skipping and raising an issue to track (most would probably make fairly good first contributions). Clearly, if these have been broken for so long I don't think they need fixing instantly however it would be good to get this in to prevent the situation from getting worse.

@h-vetinari h-vetinari changed the title BENCH: debug benchmarks BENCH: update asv, fail benchmark CI on errors, fix fallout Aug 22, 2023
@h-vetinari
Copy link
Member Author

h-vetinari commented Aug 22, 2023

@HaoZeke, are you fine with the compressed form of #18857 here? Then I think we'd be ready to fix this issue.

@mdhaber @tupui @rgommers feedback welcome, otherwise I'm planning to merge this without much further changes (and would open a follow-up issue for fixing the failing-and-now-skipped benchmarks).

@HaoZeke
Copy link
Contributor

HaoZeke commented Aug 22, 2023

@HaoZeke, are you fine with the compressed form of #18857 here? Then I think we'd be ready to fix this issue.

Yup, thanks for seeing this through 😊

@h-vetinari h-vetinari merged commit 042385d into scipy:main Aug 24, 2023
24 checks passed
@h-vetinari h-vetinari deleted the asv branch August 24, 2023 11:23
@j-bowhay j-bowhay added this to the 1.12.0 milestone Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmarks Running, verifying or documenting benchmarks for SciPy CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure DX Everything related to making the experience of working on SciPy more pleasant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI/BENCH: Fail on error BUG: python dev.py bench fails
3 participants