Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: more potential cleanups related to version bumps #20458

Open
tylerjereddy opened this issue Apr 12, 2024 · 2 comments
Open

MAINT: more potential cleanups related to version bumps #20458

tylerjereddy opened this issue Apr 12, 2024 · 2 comments
Labels
good first issue Good topic for first contributor pull requests, with a relatively straightforward solution maintenance Items related to regular maintenance tasks
Milestone

Comments

@tylerjereddy
Copy link
Contributor

Minimum NumPy version is high enough to remove

def test_moments(self):
message = 'Needs NumPy 1.22.0 for multinomial broadcasting'
if Version(np.__version__) < Version("1.22.0"):
pytest.skip(reason=message)

Minimum NumPy version is wrong here (see pyproject.toml for truth)

scipy/scipy/__init__.py

Lines 67 to 69 in efff26b

from scipy._lib import _pep440
# In maintenance branch, change to np_maxversion N+3 if numpy is at N
np_minversion = '1.22.4'

pytest 3.6.0 is six years old and the last stable release prior to it is not functional with our current test suite (I tried with 3.5.1, it errored out as expected).

scipy/scipy/conftest.py

Lines 36 to 39 in efff26b

if _pep440.parse(pytest.__version__) >= _pep440.Version("3.6.0"):
mark = item.get_closest_marker(name)
else:
mark = item.get_marker(name)

if _pep440.parse(pytest.__version__) >= _pep440.Version("3.6.0"):
markers = getattr(method, 'pytestmark', [])
for mark in markers:
if mark.name in ('skipif', 'skip', 'xfail', 'xslow'):

@tylerjereddy tylerjereddy added good first issue Good topic for first contributor pull requests, with a relatively straightforward solution maintenance Items related to regular maintenance tasks labels Apr 12, 2024
@tylerjereddy tylerjereddy added this to the 1.14.0 milestone Apr 12, 2024
@aologan
Copy link

aologan commented Apr 20, 2024

Hi new to this. Just wanna make sure I understand. For the one below you want lines 3777 - 3779 removed
Minimum NumPy version is high enough to remove

def test_moments(self):
message = 'Needs NumPy 1.22.0 for multinomial broadcasting'
if Version(np.__version__) < Version("1.22.0"):
pytest.skip(reason=message)

@lucascolley
Copy link
Member

Hi new to this. Just wanna make sure I understand. For the one below you want lines 3777 - 3779 removed

Yep, that's right 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good topic for first contributor pull requests, with a relatively straightforward solution maintenance Items related to regular maintenance tasks
Projects
None yet
Development

No branches or pull requests

4 participants
@tylerjereddy @lucascolley @aologan and others