WIP - MAINT: more potential cleanups related to version bumps #20458 #20459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
scipy.stats
maintenance
There was a problem hiding this comment.
Diff looks "ok" so far.
Testing pytest versions that won't break unless there is already consensus on a version to validate against
I believe those pytest version guards to support old versions can just be removed, we can't successfully run tests with pytest that old anymore.
peppedilillo
added a commit
to peppedilillo/scipy
that referenced
this pull request
May 14, 2024
After checking discussion to PR scipy#20459, found that the pytest guards could be removed. So I did, and removed a couple imports and a function which would became unused too. Also, this commit fixes an horrible error with the previous one, which would ban import prior to NumPy 2.0.0. (sorry! and thanks @tylerjereddy) To fix this I change the numpy minimum version of `scipy/__init__.py` to `1.23.5` as user JacobOgle did with PR scipy#20459. Thanks Jacob!
tylerjereddy
pushed a commit
that referenced
this pull request
May 14, 2024
* The minimum numpy version in `scipy/scipy/__init__.py` has been aligned to the minimum requirement of `pyproject.toml`. * A numpy version check has been removed from test `test_moments` in `scipy/stats/tests/test_multivariate.py` because the check looked for a numpy version earlier than the minimum. * After checking discussion to PR #20459, found that the pytest guards could be removed. So I did, and removed a couple imports and a function which would became unused too. Co-authored-by: jacobogle <jacob.ogle94@outlook.com>
|
Superseded by gh-20711, but I did add the original author of this PR to the commit from the other one, given that they were "competing" PRs, just to be conservative on credit, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
#20458
What does this implement/fix?
Code cleanup for outdated dependencies
Additional information
Currently a WIP. Testing pytest versions that won't break unless there is already consensus on a version to validate against