Skip to content

/ scipy

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: spatial.ConvexHull triggers a seg. fault when given nans. #5450

Closed
WarrenWeckesser opened this issue Nov 2, 2015 · 0 comments
Closed

BUG: spatial.ConvexHull triggers a seg. fault when given nans. #5450

WarrenWeckesser opened this issue Nov 2, 2015 · 0 comments
Labels
defect prio-high scipy.spatial
Milestone
0.17.0

Comments

@WarrenWeckesser
Copy link
Member

@WarrenWeckesser WarrenWeckesser commented Nov 2, 2015

This was reported on the Anaconda support email list: https://groups.google.com/a/continuum.io/forum/#!topic/anaconda/FB9KRzGzVHI

I can reproduce the problem on a Mac running OS X 10.9.5 with scipy master:

In [1]: import numpy as np

In [2]: np.__version__
Out[2]: '1.10.1'

In [3]: import scipy

In [4]: scipy.__version__
Out[4]: '0.17.0.dev0+729e5fb'

In [5]: from scipy import spatial

In [6]: points = [[0, 1], [1, 0], [2, 1], [float('nan'), float('nan')]]

In [7]: h = spatial.ConvexHull(points)
/Users/warren/anaconda/bin/python.app: line 3: 71201 Segmentation fault: 11  /Users/warren/anaconda/python.app/Contents/MacOS/python "$@"
~$
bernardosulzbach added a commit to bernardosulzbach/scipy that referenced this issue Nov 7, 2015
@bernardosulzbach
spatial.ConvexHull raises a ValueError for NaNs.
f4eb2f9 
It used to trigger a Segmentation Fault, which is not a very elegant
way to show that something is wrong. As it should not try to figure
something out of NaNs, it beautifully resigns with a ValueError now.

Fixes scipy#5450
bernardosulzbach added a commit to bernardosulzbach/scipy that referenced this issue Nov 7, 2015
@bernardosulzbach
spatial.ConvexHull raises a ValueError for NaNs.
36645e9 
It used to trigger a Segmentation Fault, which is not a very elegant
way to show that something is wrong. As it should not try to figure
something out of NaNs, it beautifully resigns with a ValueError now.

Fixes scipy#5450
bernardosulzbach added a commit to bernardosulzbach/scipy that referenced this issue Nov 7, 2015
@bernardosulzbach
ConvexHull should raise ValueError for NaNs.
c40ab63 
It used to trigger a Segmentation Fault, which is not a very elegant
way to show that something is wrong. As it should not try to figure
something out of NaNs, it beautifully resigns with a ValueError now.

Fixes scipy#5450
@bernardosulzbach bernardosulzbach mentioned this issue Nov 7, 2015
Merged
bernardosulzbach added a commit to bernardosulzbach/scipy that referenced this issue Nov 8, 2015
@bernardosulzbach
_Qhull should raise ValueError for NaNs.
cd7a6e6 
ConvexHull would trigger a Segmentation Fault, which is not a very
elegant way to show that something is wrong. As it should not try to
figure something out of NaNs, it beautifully resigns with a ValueError
now.

This also reflects on the behavior of Delaunay.

Tests that would pass if they didn't have NaNs have been written for
both classes.

Fixes scipy#5450
@pv pv closed this in #5471 Nov 15, 2015
@pv pv added this to the 0.17.0 milestone Nov 15, 2015
@hmaarrfk hmaarrfk mentioned this issue Feb 4, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect prio-high scipy.spatial
Projects
None yet
Milestone
0.17.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@pv @WarrenWeckesser