-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Compressed matrix indexing should return a scalar #10207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like SciPy CI isn't running at the moment! Or at least not showing up in the PR at the time of writing.
It should be possible to write a short regression test for this, right?
Added extra check into the existing indexing test. Or would it be better as its own test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the fix.
I think the test is fine currently. Just need to wait for the CI to come back. |
3769677
to
30ea379
Compare
30ea379
to
2e50adc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, there's an approving review on the code + test from CJ and CI is all green now so I'll put this in, thanks @peterbell10 & CJ.
Fixes gh-10206
This matches how indexing was done prior to 1.3:
scipy/scipy/sparse/compressed.py
Lines 885 to 889 in a905607