Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: special: add an explicit NaN check for iv arguments #10675

Merged
merged 1 commit into from
Aug 16, 2019

Conversation

person142
Copy link
Member

Reference issue

Closes gh-10656.

What does this implement/fix?

This adds a check for NaN arguments in special.iv and returns NaN in those cases.

Additional information

@RizzerOnGitHub can you confirm that this fixes your issue?

Copy link
Contributor

@drew-parsons drew-parsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. test_nan_inputs[iv] now passes on all architectures,
see https://buildd.debian.org/status/package.php?p=python-scipy&suite=experimental

(there are various failures in other tests, which for some reason don't cause the Debian builds to fail for hppa, riscv64, sparc64. But test_nan_inputs[iv] now passes)

@pv pv merged commit f62a890 into scipy:master Aug 16, 2019
@pv pv added this to the 1.4.0 milestone Aug 16, 2019
@pv
Copy link
Member

pv commented Aug 16, 2019

@RizzerOnGitHub: if there are now failures for other functions in test_nan_inputs, could you update and reopen the issue gh-10656, thanks!

@drew-parsons
Copy link
Contributor

Thanks @pv . Just to clarify, all test_nan_inputs tests now pass. The other failing tests are in other tests or other submodules.

@person142 person142 deleted the iv-nan-inputs branch August 16, 2019 17:19
@drew-parsons
Copy link
Contributor

And looking more closely at the other test failures, most of them seem to be a question of tolerance, akin to the problems reported in Issue #7535

@person142
Copy link
Member Author

If it's a small tolerance issue we usually just bump the tolerances a bit since floating point determinacy is not always as good as one would like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_nan_inputs hangs on some architectures (hppa, riscv64, sparc64)
3 participants