Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _peak_finding.py #11025

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Update _peak_finding.py #11025

merged 1 commit into from
Nov 7, 2019

Conversation

macrocosme
Copy link
Contributor

Fix typo: prominenence --> prominence

Reference issue

What does this implement/fix?

Additional information

Fix typo: prominenence --> prominence
@e-q e-q merged commit 520b27e into scipy:maintenance/1.3.x Nov 7, 2019
@e-q
Copy link
Contributor

e-q commented Nov 7, 2019

Thanks @macrocosme.

e-q pushed a commit that referenced this pull request Nov 7, 2019
Fix typo: prominenence --> prominence
[ci skip]
rgommers pushed a commit that referenced this pull request Nov 8, 2019
Fix typo: prominenence --> prominence
[ci skip]
@tylerjereddy
Copy link
Contributor

Please don't merge PRs directly into maintenance branches like this--the standard workflow is pretty much always to merge into master and then backport if warranted. At this stage, typo fixes are probably more churn than it is worth for 1.3.2.

@tylerjereddy tylerjereddy added this to the 1.3.2 milestone Nov 9, 2019
tylerjereddy added a commit to tylerjereddy/scipy that referenced this pull request Nov 9, 2019
* update release notes for rogue PR
(typo fix in scipygh-11025) merged directly
into the 1.3.x maintenance branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants