-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] fix rvs output shape in multivariate distributions #11150
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI failures are real:
|
rgommers
reviewed
Jan 18, 2020
|
||
size = np.asarray(size) | ||
if size.ndim != 0: | ||
all_axes_count = len(out.shape) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
len(out.shape)
--> out.ndim
This was referenced Dec 8, 2020
We do want to fix this, but we need to be careful to warn users in advance. This PR would make the change immediately and it has merge conflicts, so I'll go ahead and close it. The need to fix this is tracked in gh-16278. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
defect
A clear bug or issue that prevents SciPy from being installed or used as expected
maintenance
Items related to regular maintenance tasks
scipy.stats
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes #7689
What does this implement/fix?
Some multivariate distributions (
multivariate_normal
,wishart
andinvwishart
)rvs
methods return output with incorrect shape. As @WarrenWeckesser noted, it is due to the indiscriminate use ofsqueeze
.Additional information
In my solution, axes that were given with the
size
parameter are being skipped bysqueeze
.