New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add overwrite argument for odr.ODR() and its test. #12204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AtsushiSakai. I think adding an overwrite
keyword here is fine as a solution. Overall this looks good, just a comment on making the test more robust.
I'm sorry, CI is broken. Give me time to fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, in it goes. Thanks @AtsushiSakai
Reference issue
fix #1892
What does this implement/fix?
add
overwrite
optional argument for odr.ODR() to prevent file exist error and its test.