Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: fix bilinear_zpk example labels #13012

Merged
merged 2 commits into from
Oct 29, 2020
Merged

DOC: fix bilinear_zpk example labels #13012

merged 2 commits into from
Oct 29, 2020

Conversation

endolith
Copy link
Member

@endolith endolith commented Oct 29, 2020

Labels were swapped by accident. As pointed out in https://mail.python.org/pipermail/scipy-dev/2020-October/024400.html

Reference issue

What does this implement/fix?

hz is the digital filter, so should be labeled H_z(e^{j \omega})

hs is the analog filter, and should be labeled H(j \omega)

Additional information

and remove redundant import
Copy link
Member

@WarrenWeckesser WarrenWeckesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @endolith, looks good.

@ilayn ilayn merged commit 2eeed79 into scipy:master Oct 29, 2020
@ilayn
Copy link
Member

ilayn commented Oct 29, 2020

Looks good indeed. Thanks all.

@ilayn ilayn added this to the 1.6.0 milestone Oct 29, 2020
@ilayn ilayn added Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org scipy.signal labels Oct 29, 2020
@endolith endolith deleted the patch-3 branch October 30, 2020 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org scipy.signal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants