-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: Continuous integration information #13995
Conversation
[skip azp] [skip actions]
I can also see that skipping multiple CI works properly 😅 I will just add to put this on a new line to make it clean (as this last commit). |
I'm not sure that we want to write a table of what we check in CI, this changes regularly. |
That's why I tried to not list all of them and wrote For local testing, I can put a line and refer to the existing doc and the checklist (EDIT: done) |
[skip azp] [skip actions]
[skip azp] [skip actions]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tupui. This is a good start. Some comments to keep it more maintainable.
You are still missing some of the key we want for this section I think: how to run things locally if CI fails. In particular for the custom steps, like refguide check and linting. Can you add the exact invocations to run those, or better - add them in http://scipy.github.io/devdocs/dev/contributor/runtests.html#runtests and link to those?
Interesting, CI did not skip this time. The only difference is the blank line. I will force push just removing the blank line to check. |
[skip azp] [skip github]
Confirmed. The blank line is incompatible and prevent the check to work. Also So I propose to remove the blank line (making it work with the blank line might be too involved for this PR) and use again |
@larsoner is this expected? |
[skip azp] [skip actions]
At least for |
Thanks for explaining @larsoner!
That would be great. I think skips naturally go at the end of the description. |
FYI, I just used |
Yes, that has always been the case. |
Shall I add anything else? Shall I write that the global skip is not working with azure so if you want to skip all you need to also add the instruction for azure? |
That doesn't work either, Azure just refuses to be skipped. I think it looks good as is. |
Merged, thanks @tupui, all. |
In the effort to improve contributing documentation (#12633), this adds information about CI.
Also fix a missing command in a quickstart guide.
Feel free to add more information and complete this 😃