-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: integrate: Add complex matrix DE solution to examples #14103
Conversation
Added examples to solve complex matrix differential equations to docstring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your first PR @topolskikevin! Nice example.
On my side (as I don't know these functions) I just have a few cosmetic comments. Let see as well if the doctests pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the mess, I used the wrong account... (Believe me, I hate to have this setup but I don't have the choice...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. You still have issues with the CI. These suggestions should fix them.
scipy/integrate/_ivp/ivp.py
Outdated
53.17531184+103.80400411j] | ||
[ -2.26105874 +22.19277664j -15.1255713 +70.19616341j | ||
-38.34616845+153.29039931j]] | ||
|
||
Specifying points where the solution is desired. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following example should be placed above as the exponential_decay
function is defined above. The examples are linked.
scipy/integrate/_ivp/ivp.py
Outdated
A couple examples of using solve_ivp to solve differential functions with | ||
complex matrix ``A``. | ||
|
||
>>> from scipy.integrate import solve_ivp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already imported above.
>>> from scipy.integrate import solve_ivp |
@nmayorov could you have a look at the example itself? I am not a user of this so I would not know if this makes sense TBH. |
@tupui The idea of this PR is to provide an example of how to use |
Can i work on it |
Hi @nitin-pandita, I am afraid there is no simple way to work on someone else's PR. I would suggest you look at other issues. |
Ok Sure |
[skip actions] [skip cirrus]
[skip actions] [skip cirrus]
[skip ci]
[skip ci]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @topolskikevin
Reference issue
Closes #13437
What does this implement/fix?
Added examples to solve complex matrix differential equations to docstring
Additional information
First commit, welcome to any feedback and changes I can follow up.