Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate AR covariance matrix of an Autoregressive model. #14379

Closed
wants to merge 2 commits into from
Closed

generate AR covariance matrix of an Autoregressive model. #14379

wants to merge 2 commits into from

Conversation

nitaifingerhut
Copy link

Reference issue

What does this implement/fix?

Additional information

@nitaifingerhut nitaifingerhut changed the title generate AR covariance generate AR covariance matrix of an Autoregressive model. Jul 10, 2021
@rkern
Copy link
Member

rkern commented Jul 10, 2021

Can you fill out the information requested in the PR template? What is this function for? How does it fit in with the rest of scipy, which has nothing else for autoregressive models? This would probably fit better in statsmodels, which does, in case it doesn't already have an equivalent.

@josef-pkt
Copy link
Member

isn't this just linalg toeplitz

@rkern
Copy link
Member

rkern commented Jul 10, 2021

Yes, the most efficient and idiomatic way to implement this would be to use scipy.linalg.toeplitz(). But my first question is "why should we add this in the absence of any other tools for autoregressive models?" It seems like statsmodels already handles this capably (keeping the efficient vector form until the last moment before using toeplitz() to expand it when needed).

@nitaifingerhut
Copy link
Author

nitaifingerhut commented Jul 11, 2021 via email

@rgommers rgommers deleted the branch scipy:master January 3, 2022 16:32
@rgommers rgommers closed this Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants