Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: raise RuntimeWarning when Boost evaluation_error is encountered #14618

Merged
merged 3 commits into from
Aug 25, 2021
Merged

FIX: raise RuntimeWarning when Boost evaluation_error is encountered #14618

merged 3 commits into from
Aug 25, 2021

Conversation

mckib2
Copy link
Contributor

@mckib2 mckib2 commented Aug 20, 2021 •
edited
Loading

Reference issue

What does this implement/fix?

  • Raises RuntimeWarning on Boost stats evaluation error
  • Returns the best current guess (could still be -- and very likely is -- very wrong)

Additional information

  • Write a test to exercise the warnings
  • Decide if RuntimeWarning is appropriate (easiest to implement quickly)

@mckib2 mckib2 mentioned this pull request Aug 20, 2021
Closed
@mckib2 mckib2 marked this pull request as ready for review August 22, 2021 02:27
@rgommers rgommers added maintenance Items related to regular maintenance tasks scipy.stats labels Aug 25, 2021
rgommers
rgommers approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design choices LGTM here and this all seems to work, so in it goes. Thanks @mckib2

@rgommers rgommers merged commit 4c3206e into scipy:master Aug 25, 2021
@rgommers rgommers added the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Aug 25, 2021
rgommers added a commit to rgommers/scipy that referenced this pull request Aug 31, 2021
@rgommers
BLD: update Meson build for Boost issue
ede2e58 
Build change synced from scipygh-14618
@JPFrancoia JPFrancoia mentioned this pull request Sep 8, 2021
Closed
@tylerjereddy tylerjereddy added this to the 1.8.0 milestone Sep 12, 2021
@tylerjereddy tylerjereddy modified the milestones: 1.8.0, 1.7.2 Oct 1, 2021
tylerjereddy pushed a commit to tylerjereddy/scipy that referenced this pull request Oct 1, 2021
@mckib2 @tylerjereddy
FIX: raise RuntimeWarning when Boost evaluation_error is encountered (s…
3048142 
…cipy#14618)

Closes scipygh-14606
@tylerjereddy tylerjereddy mentioned this pull request Oct 1, 2021
Merged
@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Oct 3, 2021
@mckib2 mckib2 mentioned this pull request Oct 9, 2021
Merged
@mckib2 mckib2 mentioned this pull request Oct 30, 2021
Closed
4 tasks
@h-vetinari h-vetinari mentioned this pull request Nov 7, 2021
Merged
3 tasks
@mattip mattip mentioned this pull request Nov 25, 2021
Closed
@h-vetinari h-vetinari mentioned this pull request Aug 1, 2022
Merged
@rgommers rgommers mentioned this pull request Sep 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

@larsoner larsoner Awaiting requested review from larsoner

Assignees
No one assigned
Labels
maintenance Items related to regular maintenance tasks scipy.stats
Projects
None yet
Milestone
1.7.2
Development

Successfully merging this pull request may close these issues.

BUG: crash / core dump when calling scipy.stats.beta.ppf with certain parameters (boost-related)
3 participants
@mckib2 @rgommers @tylerjereddy