Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Refactor GitHub Issue form templates #14669

Merged
merged 2 commits into from
Sep 2, 2021
Merged

ENH: Refactor GitHub Issue form templates #14669

merged 2 commits into from
Sep 2, 2021

Conversation

HarshCasper
Copy link
Contributor

Reference issue

N/A

What does this implement/fix?

This PR updates the GitHub YAML-based Forms for Issue templates which the contributors need to fill, to file in an issue. The relevant discussion with @rgommers and @tupui can be visited here: #14493

Additional information

The screenshots for the changes

image

image

Copy link
Member

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @HarshCasper. I have a few suggestions.

.github/ISSUE_TEMPLATE/Bug_report.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/Feature_request.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/Bug_report.yml Outdated Show resolved Hide resolved
@tupui tupui added the github Items related to the code repository label Aug 31, 2021
Copy link
Member

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @HarshCasper! I have two suggestions (I will commit now for conveniency).

@rgommers since you had some inputs in the previous PR, is this ok for you? (BTW, I don't have rights to cancel azure jobs, is this intended? or can you enable this?)

.github/ISSUE_TEMPLATE/Bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/Bug_report.yml Show resolved Hide resolved
@tupui
Copy link
Member

tupui commented Sep 2, 2021

@rgommers fine with you? I would merge now as the current state is quite hard to use.

@rgommers
Copy link
Member

rgommers commented Sep 2, 2021

go for it!

@tupui tupui merged commit a7e176b into scipy:master Sep 2, 2021
@HarshCasper HarshCasper deleted the Issue-Template-Refactor branch September 2, 2021 14:59
@rgommers
Copy link
Member

rgommers commented Sep 2, 2021

This completely removed the Blank report. How do we get the original back? It's the one I use almost exclusively ....

@HarshCasper
Copy link
Contributor Author

This completely removed the Blank report. How do we get the original back? It's the one I use almost exclusively ....

Shall I add a blank markdown template then?

@rgommers
Copy link
Member

rgommers commented Sep 3, 2021

that sounds good, thanks Harsh

@HarshCasper
Copy link
Contributor Author

that sounds good, thanks Harsh

I will add it in the next PR

@tylerjereddy tylerjereddy added this to the 1.8.0 milestone Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github Items related to the code repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants