Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: optimize: Add TFQMR method to approximate the inverse of the Jacobian in "Newton-Krylov" and "root" #14862

Closed
wants to merge 3 commits into from

Conversation

zhaog6
Copy link
Contributor

@zhaog6 zhaog6 commented Oct 15, 2021

Reference issue

What does this implement/fix?

In this PR, just like GMRES etc., TFQMR method can be used to approximate the inverse of the Jacobian in the process of solving nonlinear equations using Newton-Krylov method and finding root.

Additional information

@zhaog6
Copy link
Contributor Author

zhaog6 commented Nov 2, 2021

Dear Andrew @andyfaff , Could you review the PR? Thanks.

@andyfaff
Copy link
Contributor

andyfaff commented Nov 2, 2021

I'm not familiar with that code (or the maths behind it), so I'm not best placed to review this PR. @mdhaber, @pv you'd be better placed than me.

(I note there's no tests with this PR).

@mdhaber
Copy link
Contributor

mdhaber commented Nov 2, 2021

Thanks for the contribution, @zhaog6 , but I am not familiar with it either. Maybe it would help find a reviewer if you would point out where (in code and primary source documents, like the original papers or a texbook) supports this.

@tylerjereddy tylerjereddy added the enhancement A new feature or improvement label Nov 3, 2021
@tylerjereddy
Copy link
Contributor

A bit of a fishing expedition, but @ev-br and @AtsushiSakai also show up in some flanking lines of the git blame so could try asking them.

@zhaog6
Copy link
Contributor Author

zhaog6 commented Nov 3, 2021

Thanks all @andyfaff @mdhaber @tylerjereddy for your suggestions, I added some test cases and I will contact Pauli@pv

@zhaog6
Copy link
Contributor Author

zhaog6 commented Nov 3, 2021

Dear Pauli @pv ,Could you review this PR? Thanks.

@rgommers
Copy link
Member

Closed because this PR is continued in gh-15981.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or improvement scipy.optimize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants