Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Add missing params to minres docstring. #14954

Merged
merged 1 commit into from Nov 2, 2021
Merged

DOC: Add missing params to minres docstring. #14954

merged 1 commit into from Nov 2, 2021

Conversation

rossbar
Copy link
Contributor

@rossbar rossbar commented Nov 1, 2021

There were three parameters from the signature of scipy.sparse.linalg.minres that were not included in the docstring. This PR adds the parameters in the correct order to the Other Parameters section.

@tylerjereddy tylerjereddy added the Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org label Nov 2, 2021
tylerjereddy
tylerjereddy approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as non-expert at least

@ilayn
Copy link
Member

ilayn commented Nov 2, 2021

Thanks @rossbar !

@ilayn ilayn merged commit 24ad852 into scipy:master Nov 2, 2021
@ilayn ilayn added this to the 1.8.0 milestone Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerjereddy tylerjereddy tylerjereddy approved these changes

Assignees
No one assigned
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org scipy.sparse.linalg
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rossbar @ilayn @tylerjereddy